Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19638] Log error message upon receiver resource creation failure #3924

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[19638] Log error message upon receiver resource creation failure #3924

merged 1 commit into from
Oct 17, 2023

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 11, 2023 •
edited by MiguelCompany
Loading

Description

This PR introduces a LOG_ERROR message to indicate that it was not possible to build a receiver resource. This can be useful in case of using SHM transport and being unable to open or regenerate a port file even after trying with all mutation tries.

Note: It can be argued if we should print the particular locator in the error message. I left it as it is in order not to expose more information than adequate

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Fixes #3535, #3536

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Oct 11, 2023
@Mario-DL Mario-DL added this to the v2.12.1 milestone Oct 11, 2023
@Mario-DL Mario-DL linked an issue Oct 11, 2023 that may be closed by this pull request
FastDDS doesn't report an error if it fails to setup reliable communication through SHM transport #3536
Closed
1 task
@richiprosima
Copy link
Contributor

Can't set status; build succeeded.

@Mario-DL
Refs #19638: Log error msg upon receiver resource creation failure
7569ebb 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test this

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Oct 17, 2023
@MiguelCompany
Copy link
Member

@richiprosima Please test mac

1 similar comment
@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@MiguelCompany MiguelCompany merged commit 77a85dd into master Oct 17, 2023
14 checks passed
@MiguelCompany MiguelCompany deleted the log/receiver_creation_fails branch October 17, 2023 10:16
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@Mario-DL @mergify
Log error message upon receiver resource creation failure (#3924)
5b6aa3c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@Mario-DL @mergify
Log error message upon receiver resource creation failure (#3924)
f692f2c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@Mario-DL @mergify
Log error message upon receiver resource creation failure (#3924)
64fa467 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
@MiguelCompany MiguelCompany mentioned this pull request Oct 24, 2023
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request Oct 26, 2023
@mergify @Mario-DL @MiguelCompany
Log warning message upon receiver resource creation failure (#3938)
be85b5e 
* Log error message upon receiver resource creation failure (#3924)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)

* Update src/cpp/rtps/participant/RTPSParticipantImpl.cpp

* Rework log upon receiver resource creation failure (#3954)

* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Oct 26, 2023
@mergify @Mario-DL @MiguelCompany
Log warning upon receiver resource creation failure (#3937)
54be56c 
* Log error message upon receiver resource creation failure (#3924)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)

* Rework log upon receiver resource creation failure (#3954)

* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.12.1
3 participants
@Mario-DL @richiprosima @MiguelCompany